slam_toolbox parameter renamed!

[dgarcu]

Important!!!

• I have checked that this issue/bug/fix/correction has not been already created before in open or closed issues.

Type of bug

• A) Typo/error in Figure/text
• B) Bug in code
• C) General comment, recommendation or petition

Issue Description

A parameter from https://github.com/SteveMacenski/slam_toolbox online async launcher has been renamed in this PR: SteveMacenski/slam_toolbox#363

More details: ros-navigation/navigation2#2240

Typo/Error Description

In the slides, chapter 6, slide 59/62:

ros2 launch slam_toolbox online_async_launch.py params_file:=[File path] use_sim_time:=true

From mentioned PR onwards, this should be:

ros2 launch slam_toolbox online_async_launch.py slam_params_file:=[File path] use_sim_time:=true

Proposal

I am aware of a new edition of the book being written, so I understand this has been updated already. However the docs from this very repo are outdated in that regard, so maybe leave this issue open until the docs are updated. 😃

Desktop:

• OS:
• ROS2 Distro:

[fmrico]

Thanks @dgarcu

I will maintain open this issue until it is fixed in the Second Edition.

Thanks!!

[AESilky]

Is this the cause of the error:
fatel error: cv_bridge/cv_bridge.h: No such file or directory

If so, can you provide the fix for it in these comments? I am getting the error and haven't yet taken the time to track it down. If there is a known fix, that would save me some time.

[Juancams]

Commented and hopefully solved in #36 ^^