Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell issues that should be fixed? #4252

Closed
ClausKlein opened this issue Dec 4, 2024 · 6 comments
Closed

codespell issues that should be fixed? #4252

ClausKlein opened this issue Dec 4, 2024 · 6 comments
Labels

Comments

@ClausKlein
Copy link

/usr/local/bin/cmake -D SPELL_COMMAND=codespell -P /Users/clausklein/Workspace/cpp/fmt-module/cmake/spell.cmake
Used config files:
    1: .codespellrc
./stagedir/include/fmt/base.h:447: iff ==> if
./stagedir/include/fmt/base.h:2403: pres ==> press
./stagedir/include/fmt/base.h:2410: pres ==> press
./stagedir/include/fmt/base.h:2493: pres ==> press
./stagedir/include/fmt/base.h:2498: pres ==> press
./stagedir/include/fmt/base.h:2500: pres ==> press
./stagedir/include/fmt/base.h:2505: pres ==> press
./stagedir/include/fmt/base.h:2510: pres ==> press
./stagedir/include/fmt/base.h:2515: pres ==> press
./stagedir/include/fmt/base.h:2520: pres ==> press
./stagedir/include/fmt/base.h:2525: pres ==> press
./stagedir/include/fmt/base.h:2528: pres ==> press
./stagedir/include/fmt/base.h:2530: pres ==> press
./stagedir/include/fmt/base.h:2533: pres ==> press
./stagedir/include/fmt/base.h:2535: pres ==> press
./stagedir/include/fmt/base.h:2681: iff ==> if
./stagedir/include/fmt/format.h:471: UInt ==> unit
./stagedir/include/fmt/format.h:472: UInt ==> unit
./stagedir/include/fmt/format.h:474: UInt ==> unit
./stagedir/include/fmt/format.h:474: UInt ==> unit
./stagedir/include/fmt/format.h:474: UInt ==> unit
./stagedir/include/fmt/format.h:821: copyable ==> copiable
./stagedir/include/fmt/format.h:1184: UInt ==> unit
./stagedir/include/fmt/format.h:1185: UInt ==> unit
./stagedir/include/fmt/format.h:1187: UInt ==> unit
./stagedir/include/fmt/format.h:1191: UInt ==> unit
./stagedir/include/fmt/format.h:1294: UInt ==> unit
./stagedir/include/fmt/format.h:1295: UInt ==> unit
./stagedir/include/fmt/format.h:1317: UInt ==> unit
./stagedir/include/fmt/format.h:1319: UInt ==> unit
./stagedir/include/fmt/format.h:1322: UInt ==> unit
./stagedir/include/fmt/format.h:1327: UInt ==> unit
./stagedir/include/fmt/format.h:1328: UInt ==> unit
./stagedir/include/fmt/format.h:1341: UInt ==> unit
./stagedir/include/fmt/format.h:1342: UInt ==> unit
./stagedir/include/fmt/format.h:1349: UInt ==> unit
./stagedir/include/fmt/format.h:1553: iff ==> if
./stagedir/include/fmt/format.h:1617: iff ==> if
./stagedir/include/fmt/format.h:1765: iff ==> if
./stagedir/include/fmt/format.h:2053: UInt ==> unit
./stagedir/include/fmt/format.h:2054: UInt ==> unit
./stagedir/include/fmt/format.h:2057: UInt ==> unit
./stagedir/include/fmt/format.h:2057: UInt ==> unit
./stagedir/include/fmt/format.h:2112: UInt ==> unit
./stagedir/include/fmt/format.h:2113: UInt ==> unit
./stagedir/include/fmt/format.h:2462: UInt ==> unit
./stagedir/include/fmt/format.h:2463: UInt ==> unit
./stagedir/include/fmt/format.h:2481: UInt ==> unit
./stagedir/include/fmt/format.h:2482: UInt ==> unit
./stagedir/include/fmt/format.h:2483: UInt ==> unit
./stagedir/include/fmt/format.h:2504: UInt ==> unit
./stagedir/include/fmt/format.h:2506: UInt ==> unit
./stagedir/include/fmt/format.h:2510: UInt ==> unit
./stagedir/include/fmt/format.h:2783: UInt ==> unit
./stagedir/include/fmt/format.h:2783: UInt ==> unit
./stagedir/include/fmt/format.h:2784: UInt ==> unit
./stagedir/include/fmt/format.h:2785: UInt ==> unit
./stagedir/include/fmt/format.h:2787: UInt ==> unit
./stagedir/include/fmt/format.h:2789: UInt ==> unit
./stagedir/include/fmt/format.h:2790: UInt ==> unit
./stagedir/include/fmt/format.h:2791: UInt ==> unit
./stagedir/include/fmt/format.h:2793: UInt ==> unit
./stagedir/include/fmt/format.h:2804: UInt ==> unit
./stagedir/include/fmt/format.h:2804: UInt ==> unit
./stagedir/include/fmt/format.h:2805: UInt ==> unit
./stagedir/include/fmt/format.h:2806: UInt ==> unit
./stagedir/include/fmt/format.h:3925: UInt ==> unit
./stagedir/include/fmt/format.h:3926: UInt ==> unit
./stagedir/include/fmt/format.h:3927: UInt ==> unit
./stagedir/include/fmt/os.h:243: WRONLY ==> WRONGLY
./stagedir/include/fmt/os.h:337: WRONLY ==> WRONGLY
./stagedir/include/fmt/os.h:422: WRONLY ==> WRONGLY
./stagedir/include/fmt/printf.h:90: iff ==> if
@vitaut
Copy link
Contributor

vitaut commented Dec 4, 2024

Unfortunately none of the suggestions look correct.

@vitaut vitaut closed this as completed Dec 4, 2024
@vitaut vitaut added the invalid label Dec 4, 2024
@ClausKlein
Copy link
Author

What means WRONLY?

@mwinterb
Copy link
Contributor

mwinterb commented Dec 4, 2024

What means WRONLY?

It maps to O_WRONLY from posix: write only.

@andreasbuhr
Copy link

Just for completeness:

  • "iff" means "if and only if". It has a different meaning than "if".
  • "pres" is a abbreviation of "presentation_type". Using "press" would be misleading.
  • "UInt" means unsigned integer. It has nothing to do with a "unit".

@ClausKlein
Copy link
Author

OK, but why not use unsigned instead of Uint?

I will add this words to the codespell ignore list, but readability of code means something different.

@mwinterb
Copy link
Contributor

mwinterb commented Dec 4, 2024

UInt is used to name a template parameter that matches any unsigned integer type... unsigned char, unsigned short, unsigned int, unsigned long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants