Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some points for this PR:
fmt/.github/workflows/linux.yml
Lines 29 to 31 in 5a8bf1f
was implicitly covered by matrix. I removed those lines, but that change does nothing for the Clang 9 C++11 build, it works as before.
fmt/.github/workflows/linux.yml
Lines 22 to 24 in 5a8bf1f
so it's not passed to CMake correctly, this led to messages like this:
find-package-test
, thus-stdlib=libc++
flag was ignored, and an incorrect standard library was used, error log;<array>
header include incompile-test
, I fixed it by using a C-style array instead ofstd::array
, error log.