Fix for "focus doesn't bubble" & format option improvement #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2012 16:48
Updated jquery.simulate.js to latest Fixed broken path in tests/jquery.js Updated test to not use jquery.simulate for keypress (simulate was failing, not the test) Fixed fnagel#241 in jquery.ui.selectmenu.js Added the option object as optional parameter to formatText
|
Sorry, for the late response. I was pretty busy the last few weeks (regular work and some festivals :-) Afaics this pull request does include some other fixes too. Please send a pull request for each issue next time, thats much easier to handle. Am I right that you additionally fixed one of these: #242, #199, #106 Your new patch works as nice as the last one. Thanks for your contribution, very appreciated! ps: you can use '#' for issues and 'r' for revisions. Try to type 'm' (when not in a textfield) for some more formatting informion! |
|
Yeah, seems like 242 and 199 are addressed with this patch. |
This was referenced Aug 30, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less hacky fix for #241