Add ability to import libraries on top of the translations file in an es6 way #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I currently use https://github.com/usabilityhub/rails-erb-loader: // i18n-js.js.erb or i18n-js-ts.erb
<%# encoding: UTF-8 %>
// Optional dependency watching
// Tell webpack to watch these files
// https://github.com/usabilityhub/rails-erb-loader#dependencies
/* rails-erb-loader-dependencies ./../config/locales/ */
import I18n from "i18n-js"
I18n.translations = <%= I18n::JS.filtered_translations.to_json %>;
export default I18nMy erb loader file: module.exports = {
test: /\.erb$/,
enforce: "pre",
exclude: /node_modules/,
use: [{
loader: "rails-erb-loader",
options: {
runner: (/^win/.test(process.platform) ? "ruby " : "") + "bin/rails runner",
env: {
...process.env,
DISABLE_SPRING: 1,
RAILS_CONFIG_EAGER_LOAD_ENABLED_IN_DEVELOPMENT: "false",
},
},
}],
} |
|
I really like your solution @PikachuEXE , but you need an extra package and change the options file in webpacker, what do you think about the solution I offer in this PR? The new option in the yml file is completely optional. |
PikachuEXE
suggested changes
Sep 18, 2019
|
LGTM |
|
Still pending change from @mcamara though |
|
@PikachuEXE done :) |
Travis tests have failedHey @mcamara, Ruby: 2.5rakeTravisBuddy Request Identifier: 638af320-ea73-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 67b502e0-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 6a66dc70-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 89671c20-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 916e50f0-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 923ceb90-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 98175550-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: 990c8ac0-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: c0a73e90-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: c18df510-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: c6ad4c30-ea75-11e9-90a0-7556777797a6 |
|
Hey @mcamara, TravisBuddy Request Identifier: d96f8b30-ea75-11e9-90a0-7556777797a6 |
|
Thanks |
|
Released in |
ghiculescu
reviewed
Oct 15, 2019
| @@ -248,6 +248,27 @@ MyNamespace.translations["en"] = { ... } | |||
| ``` | |||
|
|
|||
|
|
|||
| ### Adding a line at the beggining of the translations file (useful for imports) | |||
|
|
|||
| Setting the `prefix: "import I18n from 'i18n-js';\n"` option will add the line at the beggining of the resultant translation file. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use rails with webpack and the i18n-js npm package all together,
import I18n from 'i18n-js';should be added to the resultanttranslations.jsfile.This PR allows an user to add the import programatically just adding the option in the
i18n-js.ymlfile.Thanks @PikachuEXE for your package, I hope you find this option useful 😄