Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand paths passed as locale dirs. #678

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Expand paths passed as locale dirs. #678

merged 1 commit into from
Dec 9, 2022

Conversation

fnando
Copy link
Owner

@fnando fnando commented Dec 9, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller
    PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into
    two PRs otherwise).
  • This PR's title starts is concise and descriptive.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or
    fixes.
  • I've updated any docs, .md files, etc… affected by this change.

What

Expand paths so it doesn't conflict with partial paths.

Why

Close #675

Known limitations

N/A

@fnando
Expand paths passed to I18nJS.listen(locales_dir:).
f45fb3f 
This will avoid errors when mixing absolute and relative paths.
@fnando fnando merged commit cd1df62 into main Dec 9, 2022
@fnando fnando deleted the listen branch December 9, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: multiple locales dir in listen configuration require to specify full path, not relative
1 participant
@fnando