Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error message for missing pluralization key rather than raising an error. #40

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Return error message for missing pluralization key rather than raising an error. #40

merged 1 commit into from
Dec 13, 2022

Conversation

fnando
Copy link
Owner

@fnando fnando commented Dec 13, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller
    PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into
    two PRs otherwise).
  • This PR's title starts is concise and descriptive.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or
    fixes.
  • I've updated any docs, .md files, etc… affected by this change.

What

Return error message for missing pluralization key rather than raising an error.

Why

Close #39

Known limitations

N/A

@fnando fnando merged commit 03924ea into main Dec 13, 2022
@fnando fnando deleted the missing-pluralization branch December 13, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Crash with missing pluralization key
1 participant
@fnando