Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
PRs).
two PRs otherwise).
Thoroughness
fixes.
.md
files, etc… affected by this change.What
Added support for the character '.' in the translation key
Why
Some translation keys can accurately reflect the translated English sentence, for example: 'Only available for Desktop. On the Mobile App, the display ecc...', so support for all punctuation characters is needed
The 3.9.2 version worked fine with dots.
Info
The lodash 'get' function splits by char '.' and looks for the keys, like
dictionary[splitKey[0]][splitKey[1]][...];
The problem is when a key contains a '.' because the lodash 'get' function interprets it not as part of the key but as a separator.
So, the solution is to use a reduce function to iterate through all the keys in the path generated by:
i18n/src/helpers/lookup.ts
Lines 34 to 36 in d4a14ca