Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oversplitting on "No. X" abbreviations #21

Closed
leitneratselerity opened this issue Feb 28, 2022 · 1 comment · Fixed by #23
Closed

Oversplitting on "No. X" abbreviations #21

leitneratselerity opened this issue Feb 28, 2022 · 1 comment · Fixed by #23
Labels
bug Something isn't working

Comments

@leitneratselerity
Copy link

leitneratselerity commented Feb 28, 2022 •
edited
Loading

Example problem:

The Company operates and franchises approximately 1,600 service center locations and is the No. 2 and No. 3 largest chain in the U.S. and Canada, respectively, by number of stores.

The No. X cases get split at the abbreviation marker.
syntok does not currently recognize the upper-case "No. X" as an abbreviation followed by a digit, only the lower-case form "no. X"
@peter-lang-dealogic peter-lang-dealogic mentioned this issue Feb 28, 2022
Merged
@fnl fnl closed this as completed in #23 Feb 28, 2022
@fnl
Copy link
Owner

fnl commented Feb 28, 2022

Fixed by PR #23

@fnl fnl added the bug Something isn't working label Feb 28, 2022
fnl added a commit that referenced this issue Feb 28, 2022
@fnl
Patch syntok to reflect on bugfixes for #21 and #22.
38b4149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "no. 1", "No. 1", "NO. 1" type abbreviation filtering. peter-lang-dealogic/syntok
2 participants
@fnl @leitneratselerity