fix not-contraction offsets + add test (resolves #15) #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for the issue noted in #15. Specifically, in the case of "don't" you now get
do @ 0, n't @ 2
when not replacing not-contractions; if you setreplace_not_contraction=True
, you will still getdo @ 0, not @ 3
because of the implicit whitespace introduction. I assumed you would still want to introduce a space in that case, because keeping the text pristine doesn't necessarily matter there.Let me know if you disagree or would like to see something changed!