-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning when docker image ends with ":latest" #113
Comments
Hey, @mairin I would like to work on this issue. Please assign me this. |
Hey, @jennydaman can you provide some more information that will help me in solving this issue. |
I am not sure what you mean by this. Here's a hacked mock-up Here the user is trying to create a plugin. They've specified the "Docker Image" (
In that box, you could include a link to a help article explaining why and how, or design a layout to provide immediate help. e.g. show a code block docker tag fnndsc/pl-surf fnndsc/pl-surf:1.0.1
docker push fnndsc/pl-surf:1.0.1 If the user's input for
Input validation code is found here ChRIS_store_ui/src/components/CreatePlugin/CreatePlugin.js Lines 223 to 242 in 0db5186
|
Ok, I got it @jennydaman. |
It is bad practice to use the
:latest
docker images, because the app (e.g. its command-line options) are subject to change in later versions.The warning message might briefly explain why it's a bad practice, and suggest a remedy:
The text was updated successfully, but these errors were encountered: