New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protected routes solution for pages that require credentials needed #51

Closed

jcaianirh opened this issue Feb 27, 2019 · 3 comments

Collaborator

jcaianirh commented Feb 27, 2019

In the Chris UI we have a protected routes solution that we can also use here in the store. https://github.com/rebecabkerr/ChRIS_ui/blob/feature/feed/src/components/common/PrivateRoute.tsx

https://github.com/rebecabkerr/ChRIS_ui/blob/feature/feed/src/routes.tsx

Collaborator

gagansk commented Apr 8, 2019

@jcaianirh , What are the features we are supposed to make private? Dashboard appears only after login already.

Collaborator Author

jcaianirh commented Apr 8, 2019

@gagansk if a user bookmarks dashboard it should be protected

Collaborator Author

jcaianirh commented Apr 18, 2019

closed with this pr: #60

jcaianirh closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment