Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy queries must be possible for plugin's name. #7

Closed
jdtzmn opened this issue Jul 16, 2018 · 5 comments
Closed

Fuzzy queries must be possible for plugin's name. #7

jdtzmn opened this issue Jul 16, 2018 · 5 comments
Assignees
Labels
enhancement Something to be improved

Comments

@jdtzmn
Copy link
Collaborator

jdtzmn commented Jul 16, 2018

See FNNDSC/ChRIS_store#2.

@jdtzmn jdtzmn added the enhancement Something to be improved label Jul 16, 2018
@gagansk
Copy link
Collaborator

gagansk commented Feb 11, 2019

Can the issue be described more? Is it Fuzzy queries must be supported for plugin search or Fuzzy queries must be used to suggest the plugin name dynamically based on the availability during creation?

@mairin
Copy link
Contributor

mairin commented Mar 30, 2021

I think this is for searching for plugins. I would say the first task here would be to get the ChRIS store up and running, add a bunch of new plugins, and then test out the search to see how exact queries must be.

@sonylomo
Copy link
Contributor

sonylomo commented Apr 1, 2021

Hey @mairin, I'd like to work on this 😁.

@sonylomo
Copy link
Contributor

sonylomo commented Apr 6, 2021

Is it ok to use a library like Fuse.js to implement fuzzy search?

@jennydaman
Copy link
Collaborator

Fuzzy search is better implemented server-side (faster).

The back-end supports partial matching of queries, for example https://chrisstore.co/api/v1/plugins/search?name=pl-fetal returns pl-fetal-brain-mask and pl-fetal-brain-assessment. More advanced fuzzy querying, such as typo correction, might be out of scope — especially because names might use esoteric abbreviations such as pl-pfdo_med2img.

I suppose the real issue for now is to correctly implement search against the /api/v1/plugins/search?name=%s endpoint.

Another related goal would be to implement OpenSearch. I've created a separate issue for this #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something to be improved
Projects
None yet
Development

No branches or pull requests

5 participants