-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OCI API for Oracle providers #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in the removal of some old concepts such as 'calls' and 'logs' (which I think are long disused and date from the v1 days?)
Mock out OCI SDK backend for this
Apps only for now. This respects the existing config precedence of env vars > Fn CLI context > OCI config file
These are just stubbed out as Oracle Functions doesn't support Triggers
This is used by the invoke code in Fn CLI, so it's required. Fortunately, we can simply extract the key information from the OCI config provider we've constructed.
Also, allow user provider to derive API endpoint entirely from OCI config
ant1eicher
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I suggest we thoroughly integration test this before using in Fn CLI, since it's a large change.
ant1eicher
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shim layer to the Oracle providers, to translate Fnv2 API to OCI API. Incoming Fnv2 requests are translated into OCI API requests made using the OCI Functions SDK, and the responses are translated back to Fnv2. This allows consumers of fn_go (namely Fn CLI) to silently have their calls routed to the OCI API when an Oracle provider is used.
The first 2 commits are quite 'noisy' as they include bumping dependency versions and regenerating the go-swagger code to bring things up-to-date.
Closes #34