Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of geometry types from System.Drawing namespace #83

Closed
anders9ustafsson opened this issue Sep 9, 2015 · 0 comments
Closed
Assignees
Milestone

Comments

@anders9ustafsson
Copy link
Contributor

To facilitate the adaptation to portable class libraries, usage of geometric types from the System.Drawing namespace (e.g. Point, SizeF, Rectangle) should be kept at a minimum. Usage should be avoided completely in the public API. Ideally, the System.Drawing geometry types should only be used when required by the signature of a called method and there is no available alternative. Cases where this might occur is when calling e.g. Graphics.DrawImage and similar methods.

There is already a suitable replacement for System.Drawing.Point in the Dicom.Imaging.Mathematics namespace, namely Point2. Types analogous to Point2 may be implemented to cover up for other System.Drawing geometry types to maximize the portability of the library.

@anders9ustafsson anders9ustafsson self-assigned this Sep 9, 2015
@anders9ustafsson anders9ustafsson added this to the 2.0.0 milestone Sep 9, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 10, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 10, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 10, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 10, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 11, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 11, 2015
anders9ustafsson added a commit to anders9ustafsson/fo-dicom that referenced this issue Sep 11, 2015
anders9ustafsson added a commit that referenced this issue Sep 13, 2015
Moved System.Drawing dependencies to separate files. Connected to #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant