Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve java kotlin interop #19

Merged
merged 3 commits into from
May 20, 2020
Merged

Improve java kotlin interop #19

merged 3 commits into from
May 20, 2020

Conversation

fo2rist
Copy link
Owner

@fo2rist fo2rist commented May 20, 2020

  • Check for nulls explicitly for Firebase data until we have Kotlin-ready
  • Make ExperimentConfigFactory extension functions better discoverable
  • Add missing test for ExperimentConfig

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #19 into master will increase coverage by 1.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     95.27%   96.85%   +1.57%     
- Complexity       57       63       +6     
============================================
  Files            20       20              
  Lines           127      127              
  Branches         10       11       +1     
============================================
+ Hits            121      123       +2     
+ Misses            3        2       -1     
+ Partials          3        2       -1     
Impacted Files Coverage Δ Complexity Δ
...o2rist/cadabra/firebase/ExperimentConfigFactory.kt 100.00% <100.00%> (+33.33%) 6.00 <0.00> (+6.00)
...main/java/com/fo2rist/cadabra/ExperimentsConfig.kt 100.00% <0.00%> (+20.00%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f133c...69bf9a4. Read the comment docs.

@fo2rist fo2rist merged commit 49b364a into master May 20, 2020
@fo2rist fo2rist deleted the improve_java_kotlin_interop branch May 20, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant