Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experiments registration/fetching API #2

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

fo2rist
Copy link
Owner

@fo2rist fo2rist commented Jun 1, 2019

Provide Cadabra instance and config as companion properties for consistency for both
Cadabra and CadabraAndroid
Allow registering experiments without Experiment object
Move Cadabra implementation to the separated file

Close https://github.com/fo2rist/cadabra/projects/1#card-22208695

Provide cadabra instance and config as companio properties for consistency for both
Cadabra and CadabraAndroid
Allow registering experiments without Experiment object
Move Cadabra implementation to the separated file
@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #2 into master will increase coverage by 2.54%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
+ Coverage     93.75%   96.29%   +2.54%     
- Complexity        0       13      +13     
============================================
  Files             2        5       +3     
  Lines            16       27      +11     
  Branches          2        1       -1     
============================================
+ Hits             15       26      +11     
  Partials          1        1
Impacted Files Coverage Δ Complexity Δ
...om/github/fo2rist/cadabraandroid/CadabraAndroid.kt 100% <100%> (ø) 0 <0> (?)
...rc/main/java/com/github/fo2rist/cadabra/Cadabra.kt 100% <100%> (+8.33%) 0 <0> (ø) ⬇️
...main/java/com/github/fo2rist/cadabra/Experiment.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...ithub/fo2rist/cadabraandroid/CadabraAndroidImpl.kt 100% <100%> (ø) 1 <1> (?)
...ain/java/com/github/fo2rist/cadabra/CadabraImpl.kt 93.75% <93.75%> (ø) 12 <12> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb43ce...e80eafc. Read the comment docs.

@fo2rist fo2rist merged commit dc3c2bb into master Jun 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the improve_base_cadabra_api branch June 1, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant