Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix United Kingdom of Great Britain and Northern Ireland #353

Merged
merged 25 commits into from
Oct 22, 2023

Conversation

XSpielinbox
Copy link
Contributor

@XSpielinbox XSpielinbox commented Oct 4, 2023

🐞 closes #343
🎁 add test cases for all years for which I could find trustworthy data (official government website via the Wayback Machine)
Unfortunately, for all years where the 1st of January was a Sunday, it was impossible to find reliable data on when New Year's Day and when 2nd January where and will be.

However, it is missing translations at the moment, as I did not know how to translate them.

@derTobsch derTobsch added this to the 0.22.0 milestone Oct 6, 2023
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
Signed-off-by: XSpielinbox <55600187+xspielinbox@users.noreply.github.com>
@XSpielinbox XSpielinbox marked this pull request as ready for review October 10, 2023 17:41
@derTobsch derTobsch merged commit 47a190f into focus-shift:main Oct 22, 2023
9 checks passed
@XSpielinbox XSpielinbox deleted the fix_gb branch October 22, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve United Kingdom holidays
2 participants