Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Canadian holidays #536

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Improve Canadian holidays #536

merged 4 commits into from
Jun 13, 2024

Conversation

kmcbride3
Copy link
Contributor

Fixes #535. Adds or corrects missing holiday descriptions in English and French in addition to updates to the Holiday definition file for Canada.

@derTobsch derTobsch added this to the 0.29.0 milestone Jun 8, 2024
@derTobsch
Copy link
Contributor

Thanks @kmcbride3 for this great update. I just looked into it and added some comments.

@kmcbride3
Copy link
Contributor Author

Thanks @kmcbride3 for this great update. I just looked into it and added some comments.

I appreciate you taking the time to review and add the comments. I've made the corrections for NB and SK's Civic holidays and responded about Victoria Day, Thanksgiving Day, and Boxing Day in NB - they're a bit of a grey area (to me, at least) as "prescribed days of rest", but I have no issues removing them if we want to stick exclusively with paid holidays.

@kmcbride3
Updated holiday type to "Unofficial" for the three "prescribed days o…
036ad02 
…f rest" in NB which are not paid public holidays.
@derTobsch derTobsch merged commit 7abeec5 into focus-shift:main Jun 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derTobsch derTobsch derTobsch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

Improve Canadian holidays
2 participants
@kmcbride3 @derTobsch