-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo: in "hidden treasures" there is no way to deactivate the trap #629
Comments
Hi, @DaviDevMod, thanks for keep an eye on the demos. I suppose that sentence isn't visible enough, or that since all other demos have a "deactivate" button, you're prone to expect one here. The point was to show at least one demo where an explicit button to deactivate isn't necessary for a focus-trap to work. Maybe we could put the sentence in a new paragraph, or make it bold, so it's more obvious? |
Oh, I am sorry. I didn't read the description. I just assumed from the title "hidden treasures" that the demo was about showing that the trap still works even when new elements appear inside of it. I guess that no changes are needed, it's only required that the user reads that short sentence. Maybe putting a word in bold could help by encouraging to read the related text. In any case I apologise for the inconvenience and I take the occasion to thank you for maintaining this open source project from which I am learning a lot. Have a great day. |
Thank you! I appreciate that. 😄 Could you update your PR to add the bold formatting? Maybe also putting that short sentence in a new paragraph would help draw additional attention to it. |
Yes, I'd love to update my PR. I will do it as soon as I get back home. |
In the live demo of "hidden treasures" there is no way to deactivate the focus trap.
One could reload the page to be again free to click and tab around.
But having a 'deactivate trap' button inside of the trap would be better.
The text was updated successfully, but these errors were encountered: