Improve mugshot messaging for facegen-only edits #22
Comments
focustense
added
usability
|
How about: "Warning: edits in FaceGen file found, but not present in any loaded plugin" ? |
|
Because of everything that's been rewritten, and the direct support coming for facegen-only overhauls, I think it will soon be possible to actually show a specific message, e.g. "Loose FaceGen" with a different color. |
focustense
added a commit
that referenced
this issue
Aug 9, 2021
These interfaces will replace the earlier, and much more simplistic, `IModResolver`, to provide a fully-scoped view of mods and components ("files" in Nexus land, "directories" in practice). Notably, this starts to add support for disabled mod detection/handling, facegen-only mods, and a much more sophisticated mod location/targeting system that can potentially recover from mod/component names being changed, and other previously profile-breaking occurrences.
Part 1 of this is just the abstraction: interfaces and DTO classes they return providing mod and component metadata.
#10 #22 #26 #72
focustense
added a commit
that referenced
this issue
Aug 9, 2021
Accepts an existing file index (so e.g. it can be completely destroyed and recreated if the target directory changes) and automatically manages archives and tracks additions/deletions to the file system. Component resolution is handled by a dependency, so that this should be able to work for any mod manager. For Vortex, this comes from the bootstrap file (metadata "DB"), and for MO2, it is read from various INI files. #10 #22 #26 #27
focustense
added a commit
that referenced
this issue
Aug 11, 2021
This is the minimum required to display and interact with a profile based on the new analysis and mod repository code, not counting the XAML changes to the main Profile page. Most of the WPF components are just extracted from the original Profile page, but made standalone in order to provide better view/viewmodel encapsulation. Not "fully" tested but all of the basic flows seem to work when integrated with the main app (TBD in a later commit). #85 #64 #61 #51 #49 #37 #26 #22 (doesn't complete any of these, but advances all of them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As identified in this comment, if a mod edits an NPC by only providing a facegen, but does not contain any record edits, the default message that gets displayed ("plugin not loaded") is confusing and misleading.
These types of edits often aren't safe and are also flagged by the build checker, so displaying a warning is still a good thing. It should just be a clearer warning, if possible.
I can't think of any consistent way to tell the difference between "plugin exists but isn't enabled" and "there actually is no plugin that edits this NPC" because, obviously, EasyNPC can't read the mod author's mind or know about every plugin that might be in a mod - at least not without massive scope creep in the form of some huge database about every mod and plugin and version. So we might have to settle for just replacing the message with one that allows for a little more ambiguity.
Still not sure about exact wording.
The text was updated successfully, but these errors were encountered: