Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block builds on invalid mod selections #50

Closed
focustense opened this issue Jul 20, 2021 · 1 comment
Closed

Block builds on invalid mod selections #50

focustense opened this issue Jul 20, 2021 · 1 comment
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request

Comments

@focustense
Copy link
Owner

As it came out in #48, and at least one informal bug report before that, if any NPCs in a profile point to invalid mods - including mods that were removed or renamed later on - the build is always going to crash.

These should already be reported as build warnings, but this isn't really a warning, it's an error. We know that the build cannot complete in this state and therefore it requires a different UI. Arguably, this should be shown prominently before even starting/showing any other build checks, and be required to be corrected.

Making this easy to correct would also be helpful, such as a filter on the Profile page by mod name (not plugin, because in this case the plugin was still valid).
@focustense focustense added enhancement New feature or request easynpc Issues/requests relating the EasyNPC app labels Jul 20, 2021
@focustense focustense added this to the v0.9-beta milestone Jul 20, 2021
@focustense focustense mentioned this issue Aug 9, 2021
Closed
focustense added a commit that referenced this issue Aug 16, 2021
@focustense
Rewrite and restructure build checks.
50b4af8 
Each build check is now independent, and implements an interface so that an IoC container can inject them all into a build checker as a list/enumerable.

Checks have also been rewritten to use the new analysis system, and not have any generic parameters. The facegen check in particular now compares head parts and produces virtually no false positives - the only ones remaining are template NPCs, to be handled in #90.

A few minor features may be missing and labeled as todos.

#26 #37 #50 #64
@focustense focustense removed this from the v0.9-beta milestone Aug 20, 2021
@focustense
Copy link
Owner Author

I'm fairly certain it's no longer possible to encounter this under normal conditions, since the default build process starts from the plugin and finds any relevant mods that do exist, and the facegen override will be ignored when creating the profile if the mod doesn't exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@focustense