Skip to content

Commit

Permalink
Disable S3 Signature v4 Streaming by default (#719)
Browse files Browse the repository at this point in the history
The STREAMING-AWS4-HMAC-SHA256-PAYLOAD streaming method is not widely
implemented in AWS SDKs, and many third-party S3 implementations don't
support this.

S3 multipart uploads are a more standard way of handling chunked
transfers in any case.
  • Loading branch information
stanhu authored Aug 13, 2024
1 parent a8518f0 commit 95b1503
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/fog/aws/storage.rb
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ def initialize(options={})
@persistent = options.fetch(:persistent, false)
@acceleration = options.fetch(:acceleration, false)
@signature_version = options.fetch(:aws_signature_version, 4)
@enable_signature_v4_streaming = options.fetch(:enable_signature_v4_streaming, true)
@enable_signature_v4_streaming = options.fetch(:enable_signature_v4_streaming, false)
validate_signature_version!
@path_style = options[:path_style] || false

Expand Down

0 comments on commit 95b1503

Please sign in to comment.