Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #641

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Create codeql.yml #641

merged 1 commit into from
Apr 30, 2022

Conversation

naveensrinivasan
Copy link
Contributor

This action runs GitHub's industry-leading semantic code analysis engine, CodeQL, against a repository's source code to find security vulnerabilities.

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning-with-codeql

https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast

This action runs GitHub's industry-leading semantic code analysis engine, CodeQL, against a repository's source code to find security vulnerabilities.

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning-with-codeql

https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast
Copy link
Member

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you help us fix the issues this revealed as well? It looks like it should be just adding escapes to the dots in those urls, so nothing fancy. Now that I know about them, I guess I'd prefer to take care of them now before we forget or they get lost. Thanks!

@naveensrinivasan
Copy link
Contributor Author

Looks good. Could you help us fix the issues this revealed as well? It looks like it should be just adding escapes to the dots in those urls, so nothing fancy.

I don't know ruby and don't want to change things that I can't test.

Now that I know about them, I guess I'd prefer to take care of them now before we forget or they get lost. Thanks!

They won't get lost. It will be there in the security tab.

I hope you understand. Thanks

@geemus
Copy link
Member

geemus commented Apr 30, 2022

Yes, I think so. Thanks.

@geemus geemus merged commit a8aede9 into fog:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants