-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDS tags issue in AWS GovCloud Account regions. #643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, I think overall they look good. I think the resource fixes look like they are probably more or less done, but I had some questions about the snapshot methods. Those seem like feature additions at this point, rather than a bug fix, so it might make things cleaner/smoother to separate them out into a separate pull request. That could also allow us to get these bug fixes in promptly, while allowing time to work through getting the additions polished up and added. Does that make sense? Are you up for separating the two things so we can address them independently? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for understanding, this looks good, thanks!
Did you need a release with this fix? |
|
@svavhal Sounds good. Thanks again for the fix. I'll plan to release early next week (I'm not online over weekends as much, so I prefer to release when I'm more likely to see if there are problems and can respond quickly). |
Released as part of v3.14.0. Thanks again! |
Fixed RDS tags issue for AWS GovCloud Account regions.