Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS tags issue in AWS GovCloud Account regions. #643

Merged
merged 2 commits into from
May 6, 2022

Conversation

svavhal
Copy link
Contributor

@svavhal svavhal commented May 4, 2022

Fixed RDS tags issue for AWS GovCloud Account regions.

Copy link
Member

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, I think overall they look good. I think the resource fixes look like they are probably more or less done, but I had some questions about the snapshot methods. Those seem like feature additions at this point, rather than a bug fix, so it might make things cleaner/smoother to separate them out into a separate pull request. That could also allow us to get these bug fixes in promptly, while allowing time to work through getting the additions polished up and added. Does that make sense? Are you up for separating the two things so we can address them independently? Thanks!

lib/fog/aws/requests/rds/add_tags_to_resource.rb Outdated Show resolved Hide resolved
lib/fog/aws/requests/rds/list_tags_for_resource.rb Outdated Show resolved Hide resolved
@svavhal svavhal requested a review from geemus May 5, 2022 06:44
@svavhal svavhal changed the title RDS and RDS Snapshot tags issue in AWS GovCloud Account regions. RDD tags issue in AWS GovCloud Account regions. May 5, 2022
Copy link
Member

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding, this looks good, thanks!

@geemus geemus merged commit d3dbe3a into fog:master May 6, 2022
@geemus
Copy link
Member

geemus commented May 6, 2022

Did you need a release with this fix?

@svavhal
Copy link
Contributor Author

svavhal commented May 6, 2022

Thanks for understanding, this looks good, thanks!
thanks @geemus

Did you need a release with this fix?
Yes please

@geemus
Copy link
Member

geemus commented May 7, 2022

@svavhal Sounds good. Thanks again for the fix. I'll plan to release early next week (I'm not online over weekends as much, so I prefer to release when I'm more likely to see if there are problems and can respond quickly).

@geemus
Copy link
Member

geemus commented May 9, 2022

Released as part of v3.14.0. Thanks again!

@geemus geemus changed the title RDD tags issue in AWS GovCloud Account regions. RDS tags issue in AWS GovCloud Account regions. May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants