s3: remove hardcoded host #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'm struggling to remember why that change was made in the first place, looks like it was back in 2019. My only concern is if this needs to always go to the main s3 host instead of a region-based host. We might need to be more sophisticated about it (ie any of the aws stuff should maybe map to this value, instead of the regional one). Are you able to test to see what happens here? |
honzasterba
force-pushed
the
s3-remove-hardcoded-hostname
branch
from
200ee45
to
cf564b9
Compare
|
updated to use the default region host unless @host has been set |
geemus
approved these changes
Apr 26, 2023
|
Thanks, I think/hope that should cover our bases. |
|
Released in v3.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #672