Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Travis config for <2.0.0 deprecation #164

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Oct 2, 2015

See #161

  • Removed <2.0.0 Rubies
  • Added Jruby9k (set it to allow failure to see how it works out first)
  • Removed 1.8.7 Gemfile

@Temikus
Copy link
Member Author

Temikus commented Oct 2, 2015

Build looks OK.

@plribeiro3000 - Versions look good?

@plribeiro3000
Copy link
Member

Sure! ❤️

@plribeiro3000
Copy link
Member

Oh, could you add a notification in README like the one we have in the main repo?

https://github.com/fog/fog#ruby-version

@Temikus
Copy link
Member Author

Temikus commented Oct 2, 2015

@plribeiro3000 👍
Copied the deprecation message into the README.

@plribeiro3000
Copy link
Member

Ouch. Sorry but you need to add the constraint to the gemspec as well. =s

@Temikus
Copy link
Member Author

Temikus commented Oct 2, 2015

@plribeiro3000 No probs, sure thing.

Added the following to gemspec:
spec.required_ruby_version = '>= 2.0'
Correct?

@plribeiro3000
Copy link
Member

Yep. Sorry for the trouble.

plribeiro3000 added a commit that referenced this pull request Oct 2, 2015
Updating Travis config for <2.0.0 deprecation
@plribeiro3000 plribeiro3000 merged commit d18398c into fog:master Oct 2, 2015
@geemus
Copy link
Member

geemus commented Oct 16, 2015

Thanks!

@Temikus Temikus deleted the reconfig_travis branch October 17, 2015 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants