Add support for partial content to support range header. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hilarious, the docs say nothing about a different header coming back. Thanks for this @tronathan. Please rebase or merge master and I'll merge this. cc @erjohnso on the documentation bug. |
|
Thanks for the fix @tronathan and thanks for flagging @icco. Put in a cl for the docs fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem seems to support the http
Range:header, however it doesn't accept the206response from google, which is required. (206 = Partial Content)The following PR adds basic support for accepting
206 Partial Content, allowing theRangeheader to be used to get objects from GCS.