-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to connect to identity_v3 endpoint even if it's not in the catalog #268
Conversation
If I understand this PR correctly, the side effect is that endpoint list returned to client contains identity endpoint only. Couldn't we a have a switch to enable/disable this "fallback" for Openstack deployments without proper identity v3 endpoint? |
Good question! To be confirmed and fixed if needed, the default behaviour should be to use v3, even if endpoint is missing, unless v2.0 is specified, because v3 is the default as v2.0 has been deprecated. So from that we shouldn't have to use a switch, provided the whole catalog is returned no matter what. |
Could you please look at it? |
If the auth url contains "v3", fog gets identityv3 url from the catalog and uses it by default. |
ps: it's the behavior of most of openstack SDKs |
@achevalet, agreed on the v3 being the default even if service is missing from catalog, the concern is about your patch where returned catalog might contain only the identity service in the list. I haven't had a chance to test it. |
If there is only 'identity' endpoint it will not be used. 'identity' is
used only if the auth_url is v2. My patch didn't change that behavior.
2017-05-18 2:46 GMT+02:00 Gilles Dubreuil <notifications@github.com>:
… @achevalet <https://github.com/achevalet>, agreed on the v3 being the
default even if service is missing form catalog, the concern is about your
patch and the catalog being returned containing *only* the identity
service in the list. I haven't had a chance to test it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMT9dUqtmQtThMLheDyCg988-1pDTA9Gks5r65TwgaJpZM4L0gpg>
.
|
@achevalet, the concern was about the content of the catalog, meanwhile I've double checked and that's fine, therefore never mind. Thanks @aufi, I tested against OSP9 which has no identityv3 endpoint set by default and the catalog is fulfilled. What's always a bit confusing is the bootstrap process for initial authentication ;) |
It may happen that identityv3 endpoint is not present in the catalog (but only v2 for local users) and public users have to connect to v3 endpoint, which is "often" the auth url - so try it