Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to connect to identity_v3 endpoint even if it's not in the catalog #268

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

achevalet
Copy link

@achevalet achevalet commented Feb 1, 2017

It may happen that identityv3 endpoint is not present in the catalog (but only v2 for local users) and public users have to connect to v3 endpoint, which is "often" the auth url - so try it

@gildub gildub merged commit 99d6737 into fog:master Feb 21, 2017
@aufi
Copy link
Member

aufi commented May 15, 2017

If I understand this PR correctly, the side effect is that endpoint list returned to client contains identity endpoint only.

Couldn't we a have a switch to enable/disable this "fallback" for Openstack deployments without proper identity v3 endpoint?

@gildub
Copy link
Collaborator

gildub commented May 16, 2017

@aufi,

Good question! To be confirmed and fixed if needed, the default behaviour should be to use v3, even if endpoint is missing, unless v2.0 is specified, because v3 is the default as v2.0 has been deprecated.

So from that we shouldn't have to use a switch, provided the whole catalog is returned no matter what.

@gildub
Copy link
Collaborator

gildub commented May 16, 2017

@achevalet,

Could you please look at it?

@achevalet
Copy link
Author

If the auth url contains "v3", fog gets identityv3 url from the catalog and uses it by default.
If v3 endpoint is not listed in the catalog, it uses the auth url (removing /auth/token, ex: https://openstack:5000/v3) as a last try before failing. It does not fallback on v2. So from what I can see, there is no need of a switch.

@achevalet
Copy link
Author

ps: it's the behavior of most of openstack SDKs

@gildub
Copy link
Collaborator

gildub commented May 18, 2017

@achevalet, agreed on the v3 being the default even if service is missing from catalog, the concern is about your patch where returned catalog might contain only the identity service in the list. I haven't had a chance to test it.

@achevalet
Copy link
Author

achevalet commented May 18, 2017 via email

@gildub
Copy link
Collaborator

gildub commented May 19, 2017

@achevalet, the concern was about the content of the catalog, meanwhile I've double checked and that's fine, therefore never mind. Thanks

@aufi, I tested against OSP9 which has no identityv3 endpoint set by default and the catalog is fulfilled. What's always a bit confusing is the bootstrap process for initial authentication ;)

@achevalet achevalet mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants