-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenNebula compute provider #2919
Conversation
|
||
def available? | ||
begin | ||
availability=true unless Gem::Specification::find_by_name("opennebula").nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are checking to see if the gem is installed, what do you think about removing it from the dependencies and require developers to add it to their gemlist? That way devs not using opennebula will not have to download an additional lib.
Thanks for the PR!! Can I get you to review my comments as well as remove any stray comments and Thanks again! |
Hi krames, Thank you very much for your quick feedback. I will try to follow your recommendations :) Thanks! |
Hi, The travis build failures are caused by aws, not by my pull request. i have the same code with passed travis builds, too https://travis-ci.org/b0e/fog/builds/25250262 |
Awesome work guys! Looking forward to see this in upstream! :) |
…ility to foreman)
This reverts commit 45e259e.
for live tests there must be a template/flavor with the name foglivetest
@krames I did a rebase.... |
@b0e Looks like that fixed it! Thanks for all of your work on this. |
Thanks! |
Hi,
we added a compute provider for OpenNebula to fog. We implemented some basic features like creating, starting, stopping and deleting virtual machines. More details are available in lib/fog/opennebula/README.md.
Any feedback is welcome!