Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenNebula compute provider #2919

Merged
merged 47 commits into from
Jun 16, 2014
Merged

OpenNebula compute provider #2919

merged 47 commits into from
Jun 16, 2014

Conversation

b0e
Copy link
Contributor

@b0e b0e commented May 13, 2014

Hi,

we added a compute provider for OpenNebula to fog. We implemented some basic features like creating, starting, stopping and deleting virtual machines. More details are available in lib/fog/opennebula/README.md.

Any feedback is welcome!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d66a2b3 on NETWAYS:feature/one_compute_provider into 742175e on fog:master.


def available?
begin
availability=true unless Gem::Specification::find_by_name("opennebula").nil?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are checking to see if the gem is installed, what do you think about removing it from the dependencies and require developers to add it to their gemlist? That way devs not using opennebula will not have to download an additional lib.

@krames
Copy link
Member

krames commented May 13, 2014

Thanks for the PR!!

Can I get you to review my comments as well as remove any stray comments and puts? It also appears that this PR breaks the build. Can you take a look at that as well?

Thanks again!

@b0e
Copy link
Contributor Author

b0e commented May 13, 2014

Hi krames,

Thank you very much for your quick feedback. I will try to follow your recommendations :)

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 292d588 on NETWAYS:feature/one_compute_provider into 742175e on fog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) when pulling ce84019 on NETWAYS:feature/one_compute_provider into 742175e on fog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.87%) when pulling edbb014 on NETWAYS:feature/one_compute_provider into 742175e on fog:master.

@b0e
Copy link
Contributor Author

b0e commented May 15, 2014

Hi,

The travis build failures are caused by aws, not by my pull request. i have the same code with passed travis builds, too https://travis-ci.org/b0e/fog/builds/25250262

@arnisoph
Copy link

Awesome work guys! Looking forward to see this in upstream! :)

b0e added 23 commits June 16, 2014 08:32
for live tests there must be a template/flavor with the name foglivetest
@b0e
Copy link
Contributor Author

b0e commented Jun 16, 2014

@krames I did a rebase....

@krames
Copy link
Member

krames commented Jun 16, 2014

@b0e Looks like that fixed it! Thanks for all of your work on this. :shipit:

krames pushed a commit that referenced this pull request Jun 16, 2014
@krames krames merged commit fd2ce62 into fog:master Jun 16, 2014
@nirvdrum nirvdrum mentioned this pull request Jun 17, 2014
@geemus
Copy link
Member

geemus commented Jun 17, 2014

Thanks!

@b0e b0e deleted the feature/one_compute_provider branch June 18, 2014 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants