python 3 upgrade;few code semantics;new py3 bytes vs all string in py2 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
love this Craft game to demonstrate stateful multiplayer game. I upgraded the python version from v2 to v3.
The fix is twofold. 1/ python3 library semantics e.g.,
QueuevsqueueorSocketServervssocketserver,thread.setDaemon(True)vsthread.daemon= True.2/ in Python 3; strings are now always Unicode so needed to decode bytes from client to string
class Handlerand encode back beforeself.request.sendall(str.encode(data))