Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSEARCH-771]. Add models, event processing, indexing, tests, README.… #607

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[MSEARCH-771]. Add models, event processing, indexing, tests, README.… #607

merged 1 commit into from
Jun 19, 2024

Conversation

BKadirkhodjaev
Copy link
Contributor

Purpose

Implement Indexing of Institutions from Kafka (MSEARCH-771)

Approach

  • Create index models
  • Create institution index
  • Create integration tests
  • Update README.md & NEWS.md
  • Test manually using mod-search, mod-inventory-storage (master branch), Postman, Kafka-UI, Elasticsearch, Kibana (please follow the Jira ticket to see the test output).

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

Implement Indexing of Campuses from Kafka (MSEARCH-770)
Create location index and process location events (MSEARCH-703)

@BKadirkhodjaev BKadirkhodjaev requested a review from a team as a code owner June 19, 2024 12:34
BKadirkhodjaev
BKadirkhodjaev commented Jun 19, 2024
View reviewed changes
src/main/resources/model/institution.json
{
"name": "institution",
"eventBodyJavaClass": "org.folio.search.model.dto.locationunit.InstitutionDto",
"reindexSupported": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-indexing is properly disabled

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

BKadirkhodjaev
BKadirkhodjaev commented Jun 19, 2024
View reviewed changes
src/main/java/org/folio/search/integration/interceptor/ResourceEventBatchInterceptor.java
"inventory.location", SearchUtils.LOCATION_RESOURCE,
"inventory.campus", SearchUtils.CAMPUS_RESOURCE
private static final Map<String, String> TOPIC_TO_RESOURCE_MAP = Map.ofEntries(
Map.entry("inventory.instance", SearchUtils.INSTANCE_RESOURCE),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed Map.of() with Map.ofEntries() to support more than 10 entries

@psmagin
Copy link
Contributor

psmagin commented Jun 19, 2024

@BKadirkhodjaev please use proper commit message during merge.
Current one: [MSEARCH-771]. Add models, event processing, indexing, tests, README.… is not meaningful.

@BKadirkhodjaev
Copy link
Contributor Author

Implement Indexing of Institutions from Kafka (MSEARCH-771)

Noted, would [MSEARCH-771]. Implement Indexing of Institutions from Kafka be sufficient on squash & merge?

@BKadirkhodjaev BKadirkhodjaev merged commit d094df4 into master Jun 19, 2024
4 checks passed
@psmagin psmagin deleted the MSEARCH-771 branch November 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM approved these changes

@azizbekxm azizbekxm azizbekxm approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@psmagin psmagin psmagin approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavpoliakov viacheslavpoliakov Awaiting requested review from viacheslavpoliakov viacheslavpoliakov is a code owner automatically assigned from folio-org/spitfire-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BKadirkhodjaev @psmagin @SerhiiNosko @azizbekxm @Saba-Zedginidze-EPAM