Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.15.1 #219

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Release 1.15.1 #219

merged 2 commits into from
Apr 23, 2020

Conversation

ryandberger
Copy link
Member

No description provided.

MikeTaylor
MikeTaylor previously requested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely you need to update the version number in package.json, too?

zburke
zburke requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta update the package.json version to 1.15.1.

@ryandberger
Copy link
Member Author

Gotta update the package.json version to 1.15.1.

Updated now, thanks!

@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ryandberger ryandberger dismissed MikeTaylor’s stale review April 23, 2020 17:44

Zak already approved package.json version update

@ryandberger ryandberger merged commit 46a37b4 into master Apr 23, 2020
@ryandberger ryandberger deleted the release-v1.15.1 branch April 23, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@skomorokh skomorokh Awaiting requested review from skomorokh

@doytch doytch Awaiting requested review from doytch

@JohnC-80 JohnC-80 Awaiting requested review from JohnC-80

@MikeTaylor MikeTaylor Awaiting requested review from MikeTaylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryandberger @zburke @MikeTaylor