STCOR-846 update session data with values from _self request #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When restoring an existing session, i.e. pulling session values from storage and merging them with results from the response to the `_self` request, allow the `_self` values to overwrite the others, including updates to the `user` and `permissions` objects. This allows name and permission changes to take effect immediately, simply by reloading, rather than requiring a sign-out/sign-in cycle. There are two main aspects to this change: * A bug fix: previously, the `_self` request omitted the `expandPermissions=true` param that is necessary to retrieve the expanded and flattened permissions, instead returning only those values that are directly assigned. * User and permissions values from the `_self` response now overwrite those from the existing session in storage. Additionally, the `tokenExpiration` value from the existing session is used as-is. Previously, it was overwritten with dummy values with the explanation that "the response from _self doesn't contain these values" ... but that's fine. The fact that the request to `_self` succeeded tells us the tokens are valid and therefore that the values in the existing session are valid. Refs STCOR-846
BigTest Unit Test Statistics 1 files ±0 1 suites ±0 11s ⏱️ ±0s Results for commit b5be7a0. ± Comparison against base commit 2b86b9e. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
JohnC-80
approved these changes
May 28, 2024
Bigtest Unit Test Results193 tests ±0 188 ✅ ±0 6s ⏱️ ±0s Results for commit 6d90bee. ± Comparison against base commit 80bda77. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring an existing session, i.e. pulling session values from storage and merging them with results from the response to the
_selfrequest, allow the_selfvalues to overwrite the others, including updates to theuserandpermissionsobjects. This allows name and permission changes to take effect immediately, simply by reloading, rather than requiring a sign-out/sign-in cycle.There are two main aspects to this change:
_selfrequest omitted theexpandPermissions=trueparam that is necessary to retrieve the expanded and flattened permissions, instead returning only those values that are directly assigned._selfresponse now overwrite those from the existing session in storage.Additionally, the
tokenExpirationvalue from the existing session is used as-is. Previously, it was overwritten with dummy values with the explanation that "the response from _self doesn't contain these values" ... but that's fine. The fact that the request to_selfsucceeded tells us the tokens are valid and therefore that the values in the existing session are valid.Refs STCOR-846