Revert "STCOR-853 do not include credential in /authn/token request" #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zburke
added a commit
that referenced
this pull request
Jun 11, 2024
…1480)" (#1486) This reverts commit d6e7af8. We don't want to _send_ old cookies, but we do want to _receive_ new cookies. `omit` ignores both. From https://developer.mozilla.org/en-US/docs/Web/API/fetch#credentials: > `omit`: Tells browsers to exclude credentials from the request, and > ignore any credentials sent back in the response (e.g., any Set-Cookie > header). We may still have a cookie exchange problem, but if we do, `credentials: "omit"` won't solve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1480
We don't want to send old cookies, but we do want to recieve new cookies.
omitignores both:We may still have a cookie exchange problem, but if we do,
credentials: "omit"won't solve it.