UIIN-2896 Show callout when user doesn't have permissions to use edit…

… MARC shortcut (#2485)
folio-org · May 23, 2024 · 88f618e · 88f618e
1 parent 399a8c6
commit 88f618e
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 6 deletions.
diff --git a/src/ViewHoldingsRecord.js b/src/ViewHoldingsRecord.js
@@ -692,7 +692,15 @@ class ViewHoldingsRecord extends React.Component {
       {
         name: 'editMARC',
         handler: handleKeyCommand(() => {
-          if (!stripes.hasPerm('ui-quick-marc.quick-marc-editor.all') || !this.isMARCSource()) {
+          if (!this.isMARCSource()) {
+            return;
+          }
+
+          if (!stripes.hasPerm('ui-quick-marc.quick-marc-holdings-editor.all')) {
+            this.calloutRef.current.sendCallout({
+              type: 'error',
+              message: <FormattedMessage id="ui-inventory.shortcut.editMARC.noPermission" />,
+            });
             return;
           }
 

diff --git a/src/ViewInstance.js b/src/ViewInstance.js
@@ -1062,7 +1062,15 @@ class ViewInstance extends React.Component {
       {
         name: 'editMARC',
         handler: handleKeyCommand(() => {
-          if (!stripes.hasPerm('ui-quick-marc.quick-marc-editor.all') || !isMARCSource(selectedInstance.source)) {
+          if (!isMARCSource(selectedInstance.source)) {
+            return;
+          }
+
+          if (!stripes.hasPerm('ui-quick-marc.quick-marc-editor.all')) {
+            this.calloutRef.current.sendCallout({
+              type: 'error',
+              message: <FormattedMessage id="ui-inventory.shortcut.editMARC.noPermission" />,
+            });
             return;
           }
 

diff --git a/src/components/ViewSource/ViewSource.js b/src/components/ViewSource/ViewSource.js
@@ -9,15 +9,21 @@ import {
   useHistory,
 } from 'react-router-dom';
 import PropTypes from 'prop-types';
-import { FormattedMessage } from 'react-intl';
+import {
+  useIntl,
+  FormattedMessage,
+} from 'react-intl';
 
 import {
   Button,
   LoadingView,
   HasCommand,
   checkScope,
 } from '@folio/stripes/components';
-import { useStripes } from '@folio/stripes/core';
+import {
+  useCallout,
+  useStripes,
+} from '@folio/stripes/core';
 import {
   MarcView,
   PrintPopup,
@@ -44,9 +50,11 @@ const ViewSource = ({
   tenantId,
   marcType,
 }) => {
+  const intl = useIntl();
   const stripes = useStripes();
   const location = useLocation();
   const history = useHistory();
+  const callout = useCallout();
   const [isShownPrintPopup, setIsShownPrintPopup] = useState(false);
   const openPrintPopup = () => setIsShownPrintPopup(true);
   const closePrintPopup = () => setIsShownPrintPopup(false);
@@ -76,7 +84,16 @@ const ViewSource = ({
     {
       name: 'editMARC',
       handler: handleKeyCommand(() => {
-        if (stripes.hasPerm('ui-quick-marc.quick-marc-editor.all')) redirectToMARCEdit();
+        if ((marcType === MARC_TYPES.BIB && !stripes.hasPerm('ui-quick-marc.quick-marc-editor.all'))
+        || (marcType === MARC_TYPES.HOLDINGS && !stripes.hasPerm('ui-quick-marc.quick-marc-holdings-editor.all'))) {
+          callout.sendCallout({
+            type: 'error',
+            message: intl.formatMessage({ id: 'ui-inventory.shortcut.editMARC.noPermission' }),
+          });
+          return;
+        }
+
+        redirectToMARCEdit();
       }),
     },
   ], [stripes, redirectToMARCEdit]);

diff --git a/translations/ui-inventory/en.json b/translations/ui-inventory/en.json
@@ -877,5 +877,6 @@
 
   "shortcut.nextSubfield": "quickMARC only: Move to the next subfield in a text box",
   "shortcut.prevSubfield": "quickMARC only: Move to the previous subfield in a text box",
-  "shortcut.editMARC": "Edit MARC record"
+  "shortcut.editMARC": "Edit MARC record",
+  "shortcut.editMARC.noPermission": "You do not have permission to edit the record."
 }