Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests using free fonts #12

Merged
merged 8 commits into from
Jul 14, 2015
Merged

Fix the tests using free fonts #12

merged 8 commits into from
Jul 14, 2015

Conversation

devongovett
Copy link
Member

The tests were disabled because of #9, so this re-enables them using freely available fonts. It also fixes some bugs not caught by the previous test fonts. There is a readme in the test/data folder which lists the fonts by license, and has links to where they can be downloaded. The only tests not yet fixed are the AAT variation glyph tests, which rely on Apple's Skia. For now, they just don't run if you're not on a Mac, where the font is installed in /Library/Fonts.

Additionally:

  • kern format 2 is now supported (used by Play-Regular.ttf in the test data).
  • We try morx before GSUB now, since more scripts are currently supported there. One of the test fonts (Khmer.ttf) has both, and we don't currently have a shaper supporting Khmer for OpenType.
  • The kern table is now applied by default when there is no GPOS kern feature.

devongovett added a commit that referenced this pull request Jul 14, 2015
Fix the tests using free fonts
@devongovett devongovett merged commit bb992b2 into master Jul 14, 2015
@devongovett devongovett deleted the tests branch July 14, 2015 05:53
devongovett added a commit that referenced this pull request Jul 14, 2015
Fix the tests using free fonts
@devongovett devongovett restored the tests branch July 14, 2015 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant