Fix the tests using free fonts #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by one of the test fonts: Play-Regular.ttf
We currently support more scripts via AAT since the shaping logic is in the font rather than in code.
devongovett
added a commit
that referenced
this pull request
Jul 14, 2015
Fix the tests using free fonts
devongovett
added a commit
that referenced
this pull request
Jul 14, 2015
Fix the tests using free fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were disabled because of #9, so this re-enables them using freely available fonts. It also fixes some bugs not caught by the previous test fonts. There is a readme in the
test/datafolder which lists the fonts by license, and has links to where they can be downloaded. The only tests not yet fixed are the AAT variation glyph tests, which rely on Apple's Skia. For now, they just don't run if you're not on a Mac, where the font is installed in/Library/Fonts.Additionally:
Play-Regular.ttfin the test data).morxbeforeGSUBnow, since more scripts are currently supported there. One of the test fonts (Khmer.ttf) has both, and we don't currently have a shaper supporting Khmer for OpenType.kerntable is now applied by default when there is noGPOSkern feature.