Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(title): implement dynamic view title feature #90

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

gj86
Copy link
Contributor

@gj86 gj86 commented Jun 21, 2024

What is this PR for?

Accept and use function as view title. This provides option to implement per view dynamic/context based title.

Does this PR fix an existing issue?

Fixes #59

Accept and use function as view title. This provides option to implement per view dynamic/context based title.
@gj86 gj86 marked this pull request as ready for review June 21, 2024 05:17
@folke folke merged commit cdb740f into folke:main Jul 7, 2024
9 checks passed
@folke
Copy link
Owner

folke commented Jul 7, 2024

ty!

folke pushed a commit that referenced this pull request Jul 7, 2024
🤖 I have created a release *beep* *boop*
---


## [1.10.0](v1.9.1...v1.10.0)
(2024-07-07)


### Features

* **title:** implement dynamic view title feature
([#90](#90))
([cdb740f](cdb740f)),
closes [#59](#59)
* **view:** add collapsed on start option to pinned views
([#89](#89))
([2546a8e](2546a8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opts.[direction].title should accept string and function
2 participants