Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on .svelte file #22

Closed
kiuKisas opened this issue May 17, 2021 · 5 comments
Closed

Doesn't work on .svelte file #22

kiuKisas opened this issue May 17, 2021 · 5 comments
Labels
done

Comments

@kiuKisas
Copy link

No description provided.

@folke
Copy link
Owner

folke commented May 17, 2021

Probably the comment parsing. Does it work with only_comments = false?

folke added a commit that referenced this issue May 18, 2021
@folke
feat: use treesitter to highlight keywords in comments only. If not a…
b3fbe23 
… TS buffer, then highlight all comments #22
@folke
Copy link
Owner

folke commented May 18, 2021

I changed the implemention that checks wether a keyword is in a comment by using treesitter instead of commenstring.

Let me know if you have any more issues!

@folke folke added the done label May 18, 2021
@kiuKisas
Copy link
Author

Just update and here is the result:
image

@folke
Copy link
Owner

folke commented May 18, 2021

Should be fixed now. I didn't check all treesitter language trees.

It should now properly highlight in any comment (for any language that supports treesitter)

image

@folke folke closed this as completed May 19, 2021
@kiuKisas
Copy link
Author

I confirm it work ! Thank's for your hard work :)

@github-actions github-actions bot mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@folke @kiuKisas