fix(trouble): compatibility with Trouble v3 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folke
changed the title
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2024-07-07) ### Features * added support for fzf-lua ([fe5a7c6](fe5a7c6)) * **fzf:** multiline by default ([8fdea2a](8fdea2a)) * **highlight:** allow extended highlighting patterns ([#185](#185)) ([#255](#255)) ([76c8fee](76c8fee)) * **highlight:** allow highlighting the full pattern ([#180](#180)) ([ad775a7](ad775a7)) ### Bug Fixes * don't use tbl_flatten. Fixes [#272](#272) ([9c104cf](9c104cf)) * **extension:** provide default icon ([#274](#274)) ([7de4e85](7de4e85)), closes [#202](#202) * **highlight:** match to the end of length `#matched` ([#288](#288)) ([a40fa7e](a40fa7e)) * **telecope:** icons highlight. ([#279](#279)) ([4573f4f](4573f4f)) * ternary evaluation in setlist for opts.open ([#252](#252)) ([c7a6a02](c7a6a02)) * **trouble:** compatibility with Trouble v3 ([#286](#286)) ([01b4599](01b4599)) ### Reverts * feat(highlight): allow highlighting the full pattern ([#180](#180)) ([996d1a7](996d1a7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank for trouble, which offers us more customization options! Now, Trouble v3 provides an
eventsconfiguration. Therefore, I believe the additional autocmd settings here are unnecessary.todo-comments.nvim/lua/trouble/sources/todo.lua
Line 21 in d58b376
To provide more explanation about "unnecessary":
Firstly, the provider parameter no longer works and should be changed to mode = 'todo'. Otherwise, due to filter failure, the autocmd set in todocomment will incorrectly refresh sources that shouldn't be processed.
https://github.com/folke/trouble.nvim/blob/e32c194558ebeb433ccfd580a34c66770bc102bd/lua/trouble/api.lua#L107
https://github.com/folke/trouble.nvim/blob/e32c194558ebeb433ccfd580a34c66770bc102bd/lua/trouble/api.lua#L16-L27
https://github.com/folke/trouble.nvim/blob/e32c194558ebeb433ccfd580a34c66770bc102bd/lua/trouble/view/init.lua#L106-L108
Secondly, as explained above, the configuration within
eventsalready provides theBufferWritePostevent.In conclusion, we need to choose the correct version to handle the compatibility issues with the older versions, and I will continue to follow up on this.
Best regards!