feat: expand next/previous API calls; deprecate skip_groups
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow fine-tuning said API calls to be able to pick the exact type of
items to select next. For example:
Selecting any item or folded group
require("trouble").next({target = {"item_any", "group_folded"}})
Selecting only 'error' and 'warning' items
require("trouble").previous({target = {"item_error", "item_warning"}})
---
Closes folke#63
This was referenced Nov 15, 2021
|
Development on the main branch is EOL. Trouble has been rewritten and will be merged in main soon. This issue/feature either no longer exists or has been implemented on dev. For more info, see https://github.com/folke/trouble.nvim/tree/dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow fine-tuning said API calls to be able to pick the exact type of items to select next. For example:
Possible target items:
"group_any","group_folded","group_unfolded","item_any","item_error","item_warning","item_information","item_hint","item_other"This list can easily be expanded in the future.
View:next_itemandView:previous_itemare practically the same, except iteration direction, so maybe it makes sense to abstract them to 1 private method. But I'm not sure about the project's coding conventions, so I'll leave it as it is.Closes #63