Skip to content

Commit

Permalink
fix(table): colored definition table top cell border overlap
Browse files Browse the repository at this point in the history
A colored definition table was still showing the table color border on the top left cell (which is not used on definition tables by design)
I first thought it was enough to change the background, but IE/Edge still showed the border on zooming, thats why i still had to use and adjust the box-shadow

Closes #883
  • Loading branch information
lubber-de authored and Sean committed Jul 25, 2019
1 parent e103541 commit b7ad310
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
15 changes: 4 additions & 11 deletions src/definitions/collections/table.less
Original file line number Diff line number Diff line change
Expand Up @@ -283,23 +283,17 @@
background: @definitionHeaderBackground;
font-weight: @definitionHeaderFontWeight;
color: @definitionHeaderColor;
box-shadow: -@borderWidth -@borderWidth 0 @borderWidth @definitionPageBackground;
box-shadow: -@coloredBorderSizeCover -@coloredBorderSize 0 @coloredBorderSizeCover @definitionPageBackground;
-moz-transform: scale(1);
}

.ui.definition.table > tfoot:not(.full-width) > tr > th:first-child {
pointer-events: none;
background: @definitionFooterBackground;
font-weight: @definitionFooterFontWeight;
color: @definitionFooterColor;
box-shadow: -@borderWidth @borderWidth 0 @borderWidth @definitionPageBackground;
}

/* Remove Border */
.ui.celled.definition.table > thead:not(.full-width) > tr > th:first-child {
box-shadow: 0 -@borderWidth 0 @borderWidth @definitionPageBackground;
}
.ui.celled.definition.table > tfoot:not(.full-width) > tr > th:first-child {
box-shadow: 0 @borderWidth 0 @borderWidth @definitionPageBackground;
box-shadow: -@coloredBorderSizeCover @coloredBorderSize 0 @coloredBorderSizeCover @definitionPageBackground;
-moz-transform: scale(1);
}

/* Highlight Defining Column */
Expand Down Expand Up @@ -330,7 +324,6 @@
border-left: @borderWidth solid @borderColor;
}


/*******************************
States
*******************************/
Expand Down
3 changes: 2 additions & 1 deletion src/themes/default/collections/table.variables
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
/* Definition */
@definitionPageBackground: @white;

@definitionHeaderBackground: transparent;
@definitionHeaderBackground: @white;
@definitionHeaderColor: @unselectedTextColor;
@definitionHeaderFontWeight: @normal;

Expand Down Expand Up @@ -202,6 +202,7 @@
/* Colors */
@coloredBorderSize: 0.2em;
@coloredBorderRadius: 0 0 @borderRadius @borderRadius;
@coloredBorderSizeCover: @coloredBorderSize / 2;

/* Inverted */
@invertedBackground: #333333;
Expand Down

0 comments on commit b7ad310

Please sign in to comment.