Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modal] multiple modals close buttons come on each other #2195

Closed
MRAlirad opened this issue Jan 5, 2022 · 4 comments
Closed

[modal] multiple modals close buttons come on each other #2195

MRAlirad opened this issue Jan 5, 2022 · 4 comments
Assignees
Labels
type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@MRAlirad
Copy link

MRAlirad commented Jan 5, 2022

Bug Report

when you have two modals on top of each other, if the height of both of them are the same and close buttons are out of the modal, the close buttons are on each other which has a bad user experience.

Steps to reproduce

  1. make the scope (browser window screen) at a big size so that the close buttons of the modal come outside of the modal scope
  2. open the background and foreground modal

Expected result

a better UI for the close buttons which are on top of each other

Actual result

the close buttons of both modals fall on top of each other (based on the modals sizes and headers height)

Testcase

https://jsfiddle.net/208c45nt/1

Screenshot (if possible)

image

Version

2.8.8

@MRAlirad MRAlirad added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jan 5, 2022
@lubber-de lubber-de added type/feat Any feature requests or improvements and removed state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jan 5, 2022
@lubber-de
Copy link
Member

I tagged this as an enhancement. In the meantime you can force the close icon to stay inside the modals regardless of the viewport size by adding inside to the close icon
See https://jsfiddle.net/lubber/3Lve8tn1/

it is mentioned in the docs here
https://fomantic-ui.com/modules/modal.html#via-existing-dom-node
image

@lubber-de
Copy link
Member

Oups, i tag this as a bug again, because the close icon from the parent modal is still clickable! 👀
See https://jsfiddle.net/lubber/zbt5ex69/1/

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug and removed type/feat Any feature requests or improvements labels Jan 5, 2022
@lubber-de lubber-de added this to the 2.9.0 milestone Jan 5, 2022
@lubber-de lubber-de self-assigned this Jan 5, 2022
@lubber-de
Copy link
Member

Fixed by #2196
See your adjusted jsfiddle here https://jsfiddle.net/lubber/dm7pj3gf/

@lubber-de lubber-de added state/has-pr An issue which has a related PR open tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Jan 6, 2022
@MRAlirad
Copy link
Author

Thank you very much for working on this enhancement 👍

@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants