-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown): add case sensitivity setting for search #1101
feat(dropdown): add case sensitivity setting for search #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code works, but as ignoreCase
is false
by default, no existing application search dropdowns will work anymore without refactoring them by adding ignoreCase:true
. (see your own jsfiddle example)
Although 2.8.0 allows breaking changes, this kind of change would be a bit too unexpected and i believe dropdowns are used a lot everywhere.
My suggestion is to make this an additional setting ignoreSearchCase
(default true
) , so ignoreCase
will only work for the labels as before
@hammy2899 @exoego @prudho @ColinFrick Your opinions? (before @aexvir is going to change it)
I agree with @lubber-de, keeping |
Yep, totally agree |
d2c0ef4
to
4611ce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs added by fomantic/Fomantic-UI-Docs#161 |
@all-contributors please add @aexvir for code |
@hammy2899 I've put up a pull request to add @aexvir! 🎉 |
Description
ignoreCase
was only used for affecting the label creation.This MR makes the filtering respect that setting, for both searches, on text and value.Instead or reusing the same variable, as that would introduce a breaking change where none of the current users will have case insensitive search, this MR adds a new setting that allows setting the case sensitivity for the item filtering
Testcase
before: https://jsfiddle.net/3we8nb7j/
after: https://jsfiddle.net/ye1hg6c4/
Closes
#932