feat(dropdown): Dropdown formatted with label like input labeled #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports the dropdown to be formatted with the label at left or right position same as `labeled input` and `action input`. This feature depends on the labeled input and only works when the theme has enabled the labeled input variation.
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
lubber-de and
prudho
lubber-de
added
lang/css
ColinFrick
approved these changes
Sep 10, 2020
lubber-de
removed
the
state/awaiting-reviews
|
@ko2in Do you have time to prepare an example PR for the docs repo? 🙂 |
lubber-de
added
state/has-docs
|
Docs added by fomantic/Fomantic-UI-Docs#282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, we will need to create a stack of dropdown and the label together as described in this issue.
This PR intends to support the dropdown to be formatted with the label at left or right position same as input element stacks with the label and the action button.
Note
This implementation is not standalone and 100% semantic because, the class name
dropdownis already used by dropdown module.At the moment, it only works when the theme has enabled the labeled input variation
@variationInputLabeledand the dropdown module needs to be the child oflabeled inputelement. If we could find any suitable alias for this module, I'll update this PR and implement as standalone extension without depending on the input element.Test Case
https://jsfiddle.net/ko2in/ucsyf3nb/
Screenshot
Closes
#1667