feat(calendar): new default constantheight false #2043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
|
Docs added by fomantic/Fomantic-UI-Docs#298 |
lubber-de
added
the
state/has-docs
exoego
approved these changes
Aug 10, 2021
prudho
approved these changes
Aug 10, 2021
|
Mmh, there is one situation where this might be annoying if it's default: When the calendar is displayed on top of the calendar field: Because of the height changes you cannot constantly click on the month arrows. Should we change the setting anyway? https://jsfiddle.net/lubber/2gw7f8ze/1/
|
|
Well this can be annoying... At my work for example, they always need to change month in calendars. Maybe we should not define it to |
|
Agree, i will close this PR, let's keep the default as it is. |
lubber-de
added
state/wont-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As proposed in #1745 (comment) this PR changes the default value for
constantheighttofalse.Whenever the first of a month is shown within the first 5 columns of a calendar, then, according to the months amount of days, a full adjacent row is added to the calendar, which is unnecessary in most cases, so i suggest to turn this setting off by default
As this is a breaking change it is supposed to be part of 2.9
Screencapture