Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): dont resize on ios touchmove #2451

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Sep 10, 2022

Description

Safari on iOS 13.1+ seem to drag html containers on touchmove by default. At least this is happening for the sidebar.

I am not quite sure if this could break existing projects as the pan-y default limits the sidebars content to only that gesture. Thinking of only default menu items, this might be ok, but other content might need other gestures(?).
The set.ios() function was already present but not used, just in case you wonder.

I would appreciate if people could test this solution in their projects on real mobile devices (not just browserstack as i did), so we probably get a better idea if this is a proper solution. If not, then we are not merging this and people simply add the css selector by themselves.

Testcase

  • Run this on Safari 13+ on iOS only
  • Open the sidebar
  • Inside the open sidebar, drag to the left

Broken

The sidebar gets shrinked
https://fomantic-ui.com/jsfiddle/#!lubber/7d2hxouf/44/

Fixed

Nothing happens as expected. Sidebar keeps its width
https://fomantic-ui.com/jsfiddle/#!lubber/7d2hxouf/43/

Closes

#2449

@lubber-de lubber-de added lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews browser/safari Any issues relating to Apple Safari device/mobile Any issues relating to mobile devices labels Sep 10, 2022
@lubber-de lubber-de added this to the 2.9.x milestone Sep 10, 2022
@lubber-de
Copy link
Member Author

lubber-de commented Oct 11, 2022

Set on hold/switch to draft because it does not seem to fix the whole issue as mentioned in #2449 (comment)

@lubber-de lubber-de added the state/on-hold Issues and pull requests which are on hold for any reason label Oct 11, 2022
@lubber-de lubber-de marked this pull request as draft October 11, 2022 07:14
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 20, 2022
@lubber-de lubber-de removed the request for review from exoego January 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/safari Any issues relating to Apple Safari device/mobile Any issues relating to mobile devices lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/on-hold Issues and pull requests which are on hold for any reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant