[Progress] Fix 0% display and "inverted indicating" label color #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value, because set.percent makes use of it
This was referenced Jan 18, 2019
Closed
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
progressFix 1
Trying to display "0%" was not recognized when given as a
data-percentordata-valueattribute. 0 was recognized as "false", thus it was not displayed at all.Fix 2
Even when 0% was displayed (using JS), the progressbar already has increased to 2em, because this is set as min-width. Reason because of this is obviously to force the percentage display any time, as the text is inside the bar and would vanish if the bar itself would had a width of 0%.
To still show "0%" but also have the bar disappear to definately show zero progress, the background color is now simply transparent when the value is 0%. Percentages >0% will show the progressbar as before.
Fix 3
If the progress was
inverted indicatingthe label below the bar was set to black. Simply because there wasn't a separate setting for the inverted variant.In addition i replaced some
!importsettings by proper specificity classesTestcase
Broken
http://jsfiddle.net/2a8gqb3d/
Fixed
http://jsfiddle.net/e2mj4fg8/
Screenshot
Broken
Fixed
Closes
Semantic-Org/Semantic-UI#6341
Semantic-Org/Semantic-UI#6445
Semantic-Org/Semantic-UI#6297
Semantic-Org/Semantic-UI-React#2672