Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Fix 0 percent bars on colored progress #463

Merged
merged 2 commits into from
Feb 5, 2019
Merged

[Progress] Fix 0 percent bars on colored progress #463

merged 2 commits into from
Feb 5, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 5, 2019 •
edited
Loading

Description

The background fix from #412 only works when the progressbar does not have a fixed color class assigned 😢

Testcase

https://jsfiddle.net/x6fyp5he/

<div class="ui red progress" data-percent="0">
  <div class="bar"></div>
</div>

Screenshot

Before After
image image

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Feb 5, 2019
@lubber-de lubber-de added this to the 2.7.3 milestone Feb 5, 2019
y0hami
y0hami approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit b817ea7 into fomantic:develop Feb 5, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 5, 2019
@lubber-de lubber-de deleted the fix/colored_progress_0percent branch February 5, 2019 16:21
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @prudho @y0hami @exoego