Refactor WorkspaceManager #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/savq/Pluto.jl", rev="wm")
julia> using Pluto |
fonsp
reviewed
Oct 17, 2022
|
Looks fine otherwise! |
savq
force-pushed
the
wm
branch
2 times, most recently
from
49cce8c
to
6f9a1fb
Compare
- Rename `workspaces` to `active_workspaces` - Prefer quote blocks to colon quote expressions - Prefer if blocks to ternary operators - Remove single pipes - Minor changes to docstrings and comments - Remove trailing whitespace
|
force push means that i have to review the whole PR a second time 😢 but I guess it looks fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes here. Just a renamed variable and formatting.
workspacestoactive_workspacesCreating this PR instead of wating on #2240 because rebasing was getting tedious.